Skip to content

Conversation

jhuynh1
Copy link
Contributor

@jhuynh1 jhuynh1 commented Apr 15, 2025

No description provided.

@jhuynh1 jhuynh1 force-pushed the prefilter-gemfire-vdb branch from 59e9a2a to 3e713b8 Compare April 15, 2025 17:06
@jhuynh1
Copy link
Contributor Author

jhuynh1 commented Apr 15, 2025

Hi @markpollack , this is a PR for adding filter queries to GemFireVectorStore. Thanks!

@sobychacko
Copy link
Contributor

@jhuynh1 I am reviewing this PR. The new test in GemFireVectorStoreIT is failing for me locally. The test is disabled by default; you need to enable it. Some other tests in the class are failing as well. It would help with the review/merge if you could look at that. Thank you!

@nabarunnag
Copy link

nabarunnag commented Jun 17, 2025

Hi, @sobychacko we have pushed a commit to the PR to fix the failing test. The failing test is passing now. Please do test it and let us know, if there is anything else we can do to get this merged.

Thank you again

@nabarunnag nabarunnag force-pushed the prefilter-gemfire-vdb branch 2 times, most recently from 5bd5d16 to b2c7baa Compare June 17, 2025 18:38
Signed-off-by: Nabarun Nag <[email protected]>
@nabarunnag nabarunnag force-pushed the prefilter-gemfire-vdb branch from b2c7baa to 2ed72a3 Compare June 17, 2025 18:41
@nabarunnag
Copy link

Tests are passing locally
Screenshot 2025-06-17 at 11 40 21 AM
Screenshot 2025-06-17 at 11 42 06 AM

@sobychacko
Copy link
Contributor

@nabarunnag Thank you for looking into it. I see that you enabled the IT test by default. I am still getting an exception when trying to run the test suite? Do you recognize anything from the following stack trace? Also, could you rebase your PR with the latest main branch? Thanks!

org.testcontainers.containers.ContainerLaunchException: Container startup failed for image gemfire/gemfire-all:10.1-jdk17

	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:351)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
	at com.vmware.gemfire.testcontainers.GemFireCluster.start(GemFireCluster.java:166)
	at org.springframework.ai.vectorstore.gemfire.GemFireVectorStoreIT.startGemFireCluster(GemFireVectorStoreIT.java:95)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:336)
	... 5 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:556)
	at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:346)
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
	... 6 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [9090] should be listening)
	at org.testcontainers.containers.wait.strategy.HostPortWaitStrategy.waitUntilReady(HostPortWaitStrategy.java:112)
	at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
	at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)
	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:492)
	... 8 more

* Disabling the test due to inconsistencies with testcontainers in different test environment.

Signed-off-by: Nabarun Nag <[email protected]>
@nabarunnag
Copy link

nabarunnag commented Jul 8, 2025

Hi @sobychacko , thank you so much for your time.

  • We have merged spring-ai/main to the pull request
  • Disabled the GemFireVectorStoreIT test.
  • Based on the discussions on this pull request we had initially disabled the test but decided on enabling the test after gemfire images were made public on docker hub.
  • We tested it on multiple test environment and the tests are passing.
  • We researched the stacktrace you are encountering while running test and we suspect it might be some network inconsistency or setting in the test environment.
  • After discussions, we are again disabling the test due to inconsistencies in the behavior of testcontainers in different test environments.
  • We decided to disable it based on similar steps that were taken in the existing tests in the codebase for eg:CoherenceVectorStoreIT

Please do reach out if there is any else we can do to get this merged.

Thank you!

@nabarunnag
Copy link

Hi @sobychacko, I hope you are doing well. Just wanted to check in and see if we need to do anything else to get this merged. Thank you for your time.

@nabarunnag
Copy link

Hi @sobychacko, checking in to see if we need to do anything else to get this merged.

@ilayaperumalg ilayaperumalg modified the milestones: 1.1.0.M1, 1.1.0.M3 Sep 25, 2025
@sobychacko
Copy link
Contributor

@nabarunnag My apologies for not getting back to this PR sooner. It fell off of our radar due to other commitments and once again, sorry. I just merged this PR to upstream main branch after squashing the individual commits, fixing the formatting, checkstyle, etc. Also, added a docs section via another commit. Please take a look.

@sobychacko sobychacko closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants